Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
zip_close()fails in the object destructor at shutdown, the "Cannot destroy the zip context" warning goes to the user error handler. If that handler throws, there is no frame to catch the exception, so it bails out in the middle ofphp_zip_archive_release(). The refcount is already 0 but the archive is never freed andintern->archiveis never cleared, sofree_storagecloses it again and hits the assertion. The warning now runs insidezend_tryand setsbailout_callbacklike the progress/cancel callbacks do, so cleanup finishes and the destructor bails out afterwards.The close warning in
php_zipobj_close()gets the same guard. It is reached when the destructor never ran (e.g. after a memory limit fatal), and bailing out there leaked the libzip handle.Fixes GH-25360